Skip to content

'str' object has no attribute 'decode' #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

'str' object has no attribute 'decode' #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions xclib/utf8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ def unutf8(u, opts='strict'):
traceback.print_exc()
return 'illegal-utf8-sequence-' + dec
else:
return u.decode('utf-8', opts)

try:
return u.decode('utf-8', opts)
except AttributeError:
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be return u instead?

Copy link
Contributor Author

@Failure404 Failure404 Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes,
but I am not familiar with the code and I thought there could be cases where the object is not already decoded.
If that's not the case, then return u sounds like the most logical approach :-)


def utf8l(l):
'''Encode a copy of the list, converted to UTF-8'''
return list(map(utf8, l))