Update types and RuleContext deprecations by tylermumford · Pull Request #3972 · jsx-eslint/eslint-plugin-react

tylermumford · 2025-12-30T22:41:39Z

Summary

On RuleContext objects, use the filename property instead of the deprecated getFilename() method. That method was marked as deprecated in ESLint v8 and is removed in ESLint v10.

Motivation

I'm preparing a company project for ESLint v10, and I get an error that eslint-plugin-react uses a method that doesn't exist on the RuleContext object.

(Hello, this is my first PR on this repo. I hope to be helpful and respectful.)

socket-security · 2025-12-30T22:48:24Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@types/eslint@7.2.10 ⏵ 8.56.12

View full report

ljharb

It'd be interesting to also add tests that run in eslint 10.

ljharb · 2026-01-06T19:03:26Z


  create(context) {
-    const filename = context.getFilename();
+    const filename = context.filename;


it's probably safer to do this since we still support much older eslint versions?

Suggested change

const filename = context.filename;

const filename = context.filename || context.getFilename();

ljharb · 2026-01-06T19:03:46Z

 function resolveBasedir(contextOrFilename) {
  if (contextOrFilename) {
-    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.getFilename();
+    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename;


Suggested change

const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename;

const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename || contextOrFileName.getFilename();

ljharb · 2026-01-06T19:04:02Z

    "@babel/plugin-syntax-function-bind": "^7.27.1",
    "@babel/preset-react": "^7.27.1",
-    "@types/eslint": "=7.2.10",
+    "@types/eslint": "=8.56.12",


we still support eslint 7 so i'm not sure we can upgrade the types - and if we do we'd use ^, not =

Bump major and drop eslint7 support?

kachkaev · 2026-01-27T16:13:37Z

@tylermumford, are you still planning to work on this PR? Hitting the same error after upgrading from v9 to v10.0.0-rc.2. @ljharb's suggestions make sense – good for backwards compatibility.

palfrey · 2026-02-07T15:09:11Z

I've just hit this myself now 10.0 is out, and happy to help if needed.

jsx-eslint#3972

Adds a "Blocked upgrades" section to docs/ops/dependency-policy.md tracking the eslint 9 → 10 bump that was held back today. eslint-plugin-react@7.37.5 (latest) caps its eslint peer at ^9.7 and ESLint 10 removed the RuleContext API the plugin uses (upstream PRs jsx-eslint/eslint-plugin-react#3972 and #3979 open, no release). PR #68 was closed via @dependabot ignore this major version. A scheduled remote agent re-checks upstream monthly. Signed-off-by: Snowboard Bot <bot@example.com> Co-authored-by: Snowboard Bot <bot@example.com>

…#116) - eslint 9.35.0 -> 10.8.0, com eslint-plugin-react/jsx-a11y/import (via eslint-config-next) ainda a chamar métodos de RuleContext que o ESLint 10 removeu (context.getFilename() e afins — correção já proposta a montante em jsx-eslint/eslint-plugin-react#3972, mas ainda não publicada). Em vez de patch manual, uso o shim oficial @eslint/compat (fixupConfigRules) em eslint.config.mjs, que restaura esses métodos no context passado a cada regra — mesma solução que a própria ESLint recomenda para este cenário exato. Remover o wrapping quando eslint-config-next publicar uma versão já compatível. - overrides.brace-expansion = "5.0.8": com o eslint já na v10 (que passa a depender de minimatch@10, compatível com o novo formato de export do brace-expansion@5.x), o override deixa de partir o eslint-plugin-import como partia antes do bump — confirmado via `npm run lint` limpo e via tests/unit/xlsx-export.test.ts (a exportação Excel usa a mesma cadeia archiver/glob por baixo). `npm audit`: 0 vulnerabilidades (era 8, todas nesta mesma cadeia eslint/archiver, depois da NEX-165 e do bump do next/sharp/uuid anteriores).

plthomasva · 2026-07-30T23:34:35Z

I believe these changes are incorporated in #4022. Thanks for getting the ball rolling.

Update types and RuleContext deprecations

a8397be

ljharb requested changes Jan 6, 2026

View reviewed changes

ledsun added a commit to ledsun/eslint-plugin-react that referenced this pull request Feb 9, 2026

Addresses the feedback provided in the comments on

0108a6a

jsx-eslint#3972

ledsun mentioned this pull request Feb 9, 2026

Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

Open

ledsun added a commit to ledsun/eslint-plugin-react that referenced this pull request Feb 11, 2026

Addresses the feedback provided in the comments on

9c686b5

jsx-eslint#3972

ledsun added a commit to ledsun/eslint-plugin-react that referenced this pull request Feb 21, 2026

Addresses the feedback provided in the comments on

d5641b0

jsx-eslint#3972

lpicchi mentioned this pull request Feb 26, 2026

ESLint v10 compatibility #3977

Open

2 tasks

ledsun added a commit to ledsun/eslint-plugin-react that referenced this pull request Mar 6, 2026

Addresses the feedback provided in the comments on

2acdb05

jsx-eslint#3972

ledsun added a commit to ledsun/eslint-plugin-react that referenced this pull request Mar 15, 2026

Addresses the feedback provided in the comments on

c5dd610

jsx-eslint#3972

ljharb force-pushed the master branch from 2df8be2 to 012ec39 Compare April 1, 2026 20:54

jonathanperis mentioned this pull request Apr 6, 2026

Bump eslint from 9.39.4 to 10.2.0 jonathanperis/jonathanperis.github.io#30

Closed

This was referenced May 2, 2026

chore(deps-dev)(deps-dev): bump eslint from 9.39.4 to 10.3.0 mathvbarone/snowboard-trip-advisor#68

Closed

docs(ops): record ESLint 10 as a blocked upgrade mathvbarone/snowboard-trip-advisor#70

Merged

mitoperni mentioned this pull request May 11, 2026

chore(eslint): migrate to ESLint 10 flat config Vizzuality/global-rangelands-data-platform#148

Merged

3 tasks

suhailsalim mentioned this pull request Jul 27, 2026

chore(deps): bump eslint from 9.39.4 to 10.8.0 akasecurity/ai-tc#114

Closed

ShadowShtr mentioned this pull request Jul 27, 2026

chore(deps): bump ESLint para v10 e fechar brace-expansion (DoS) ShadowShtr/NEXORA#116

Merged

Navigation Menu

Uh oh!

Uh oh!

Update types and RuleContext deprecations - #3972

Update types and RuleContext deprecations#3972
tylermumford wants to merge 1 commit into
jsx-eslint:masterfrom
tylermumford:update-deprecated-calls-v8

tylermumford commented Dec 30, 2025

Uh oh!

socket-security Bot commented Dec 30, 2025

Uh oh!

ljharb left a comment

Uh oh!

ljharb Jan 6, 2026

Uh oh!

ljharb Jan 6, 2026

Uh oh!

ljharb Jan 6, 2026

Uh oh!

ipanasenko Feb 26, 2026

Uh oh!

kachkaev commented Jan 27, 2026 •

edited

Loading

Uh oh!

palfrey commented Feb 7, 2026

Uh oh!

plthomasva commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

	const filename = context.filename;
	const filename = context.filename \|\| context.getFilename();

	const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename;
	const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename \|\| contextOrFileName.getFilename();

Uh oh!

Uh oh!

Conversation

tylermumford commented Dec 30, 2025

Summary

Motivation

Uh oh!

socket-security Bot commented Dec 30, 2025

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

ljharb Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

ljharb Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

ljharb Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

ipanasenko Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

kachkaev commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

palfrey commented Feb 7, 2026

Uh oh!

plthomasva commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

kachkaev commented Jan 27, 2026 •

edited

Loading