Add --fix-type support #3165
Add --fix-type support #3165
Conversation
1) Add the type field in rule's meta 2) Fix the fixable field
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
sryze
force-pushed
the
type-fix-support-2
branch
from
0cc60a3 to
3e7ebd5
Compare
|
Rebased |
| url: docsUrl('jsx-closing-bracket-location'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
There was a problem hiding this comment.
why is this change correct?
(if it is correct, i'd like to land it separately, before this PR)
There was a problem hiding this comment.
it was part of the original PR
I'm not 100% sure what this property means because the documentation doesn't mention what is the difference between code and whitespace; possibly whitepsace means that a fix will only change whitespace characters
There was a problem hiding this comment.
@ljharb I've reverted the changes to fixable and category in made by the previous PR author as they are not related to --fix-type (purpose of this PR); please have a look, thanks!
There was a problem hiding this comment.
looks like this change was correct, because the fix changes only spacing before the bracket (indents + newline), see eslint/eslint#15489 (comment)
There was a problem hiding this comment.
@sryze can we make a separate PR that changes all the "code"s to "whitespace"s?
lib/rules/jsx-curly-spacing.js
Outdated
| url: docsUrl('jsx-curly-spacing'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
lib/rules/jsx-equals-spacing.js
Outdated
| url: docsUrl('jsx-equals-spacing'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
lib/rules/jsx-first-prop-new-line.js
Outdated
| url: docsUrl('jsx-first-prop-new-line'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
lib/rules/jsx-indent-props.js
Outdated
| url: docsUrl('jsx-indent-props'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
| url: docsUrl('jsx-props-no-multi-spaces'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
| url: docsUrl('jsx-space-before-closing'), | ||
| }, | ||
| fixable: 'code', | ||
| fixable: 'whitespace', |
lib/rules/no-array-index-key.js
Outdated
| category: 'Best Practices', | ||
| category: 'Possible Errors', |
There was a problem hiding this comment.
changing the category is a breaking change; also, this is indeed a best practice, and does not necessarily indicate a problem.
lib/rules/no-typos.js
Outdated
| category: 'Stylistic Issues', | ||
| category: 'Possible Errors', |
There was a problem hiding this comment.
this is a breaking change, and also should be done in a separate PR.
| category: 'Best Practices', | ||
| category: 'Possible Errors', |
ljharb
force-pushed
the
master
branch
6 times, most recently
from
59af733 to
865ed16
Compare
ljharb
force-pushed
the
master
branch
4 times, most recently
from
069314a to
181c68f
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
380e32c to
51d342b
Compare
2 participants
Add
typeproperty to all rules to support usage of eslint's--fix-typeoptionFixes #2618. Fixes #2039.
Successor of this PR: #2619