[New] component detection: track React imports #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test detection of Class Components and Stateless Function Components Lay scaffolding for other flavors of tests including further component types, pragma detection, and utils functions
The default React import and named React import specifiers are tracked during a Components.detect rules definition. Rules using Components.detect can access the default import specifier using `components.getDefaultReactImport()` and an array any named import specifiers using `components.getNamedReactImports()` Within a rule, these specifier nodes can be checked to ensure identifiers in scope correspond with the imported identifiers. Not treating this as semver-minor since it's not part of the documented API.
ljharb
requested changes
Nov 26, 2021
duncanbeevers
commented
Nov 28, 2021
ljharb
force-pushed
the
components-util-react-imports
branch
from
dddf6c2 to
146eefb
Compare
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
=======================================
Coverage 97.50% 97.51%
=======================================
Files 119 119
Lines 8103 8129 +26
Branches 2888 2895 +7
=======================================
+ Hits 7901 7927 +26
Misses 202 202
Continue to review full report at Codecov.
|
ljharb
approved these changes
Nov 28, 2021
ljharb
changed the title
|
Note: I'm not treating this as semver-minor, since it's not really part of the public API. |
ljharb
force-pushed
the
components-util-react-imports
branch
from
146eefb to
a09debf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of basic tests to the existing
Components.detectfunctionality.Next it adds a facility for detecting the imported React identifiers during a parse, and adds a simple test for that detection.
This is an extraction of work initiated in #2921 and supports that PR
I think having a test runner for the
Components.detectutility was worthwhile in itself, and separated that test-runner functionality into its own commit.