Skip to content

Fix set state callback destructing & state use inside callback #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2019
Merged

Fix set state callback destructing & state use inside callback #2151

merged 1 commit into from
Feb 2, 2019

Conversation

barakyosi
Copy link

@barakyosi barakyosi commented Feb 2, 2019 •
edited by ljharb
Loading

Fix no-unused-state rule:

  1. When using destruction in setState callback.
  2. When using state inside setState callback.

Fixes #1697

This is my first PR to open source :)

ljharb
ljharb requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Awesome start.

@ljharb ljharb added the bug label Feb 2, 2019
@ljharb ljharb force-pushed the fix_no_unused_state branch from e8292fd to 4270205 Compare February 2, 2019 21:26
@ljharb ljharb merged commit 4270205 into jsx-eslint:master Feb 2, 2019
@barakyosi barakyosi deleted the fix_no_unused_state branch February 3, 2019 09:10
@barakyosi barakyosi mentioned this pull request Feb 8, 2019
Closed
This was referenced Aug 17, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barakyosi @ljharb