Skip to content

[Docs] create setup.md #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiefling
Copy link

Root file for the docs directory to help newbies (like me) find info on setting up the plugin.

Root file for the docs directory to help newbies find info on setting up the plugin.
@ljharb
Copy link
Member

ljharb commented May 13, 2020

@tiefling ping, any interest in completing this PR?

@tiefling
Copy link
Author

I'm not sure that I can - I only have an option to Close it.

@tiefling
Copy link
Author

@ljharb - Do I have to resolve the comments first? (not done this through GitHub before)

@ljharb
Copy link
Member

ljharb commented May 13, 2020

@tiefling when they're resolved, you can click "resolve" - but the main thing is, updating the PR branch with the suggested changes :-) i can resolve things, rebase, and merge once the content is ready.

@tiefling
Copy link
Author

tiefling commented May 13, 2020 via email

@ljharb
Copy link
Member

ljharb commented May 13, 2020

Thanks, that would be appreciated :-)

@tiefling
Copy link
Author

@ljharb - I think this is good now - I can't merge but it should be good to merge in now.

@tiefling
Copy link
Author

All resolved and ready to merge

@ljharb ljharb changed the title Create setup.md [Docs] create setup.md Jun 28, 2020
@ljharb ljharb force-pushed the tiefling-setup-docs-info branch from 38456f3 to 119b8b0 Compare June 28, 2020 21:12
Comment on lines +3 to +10
1. At the root of your project type <code>npm install --save-dev eslint-plugin-react</code>
2. Check your package.json 'devDependencies' for the following entries (version numbers may vary, but it's important that **the eslint version matches the peerDependency version in eslint-plugin-react**)...
<pre>
"devDependencies": {
"eslint": "^7.3.1",
"eslint-plugin-react": "^7.10.3"
}
</pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +31 to +35
"no-unused-vars": 2,
"react/jsx-uses-vars": 2,
"react/require-extensions": 0,
"react/jsx-sort-prop-types": 0,
"react/prop-types": [2, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"no-unused-vars": 2,
"react/jsx-uses-vars": 2,
"react/require-extensions": 0,
"react/jsx-sort-prop-types": 0,
"react/prop-types": [2, {
"no-unused-vars": "error",
"react/jsx-uses-vars": "error",
"react/require-extensions": "off",
"react/jsx-sort-prop-types": "off",
"react/prop-types": ["error", {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants