Consider adding no-access-state-in-setstate to recommended

[noahbenham]

Using this.state within setState is a very common pattern for developers new to React. This practice can lead to insidious bugs. Should react/no-access-state-in-setstate be part of the recommended set instead of asking consumers to manually enable it?

I'm happy to open a PR but wanted to start a discussion first in case omission was intentional.

[ljharb]

Adding new things to the recommended set is a breaking change; it's not worth doing imo unless we're already doing one (at which point we'd re-evaluate all rules in the recommended set)

[mat8913]

Too many false positives with this.

[ljharb]

@mat8913 regardless of whether this is recommended or not; it'd be great if you filed issues for the false positives. If it's possible to eliminate them (or move them behind options) that'd be an improvement.

[michaeljseiter]

@ljharb 👋  Just curious on your thoughts here; does React 18 extending batching beyond event handlers move the needle on making react/no-access-state-in-setstate a definite choice for "recommended" in the v8 release of the eslint-plugin-react?

[ljharb]

@JustinSeiter i'm already on board with doing that; that still doesn't mean we're likely to do a semver-major release any time soon.

[michaeljseiter]

@ljharb Awesome! And no worries on the semver-major release. Appreciate the feedback. Ty ty!