fix(transloco): prevent loading translations when injector is destroyed #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsverse/transloco
@jsverse/transloco-locale
@jsverse/transloco-messageformat
@jsverse/transloco-optimize
@jsverse/transloco-persist-lang
@jsverse/transloco-persist-translations
@jsverse/transloco-preload-langs
@jsverse/transloco-schematics
@jsverse/transloco-scoped-libs
@jsverse/transloco-utils
@jsverse/transloco-validator
commit: |
arturovt
force-pushed
the
fix/transloco-destroyed
branch
2 times, most recently
from
052aa36 to
4396168
Compare
|
@shaharkazaz friendly ping. |
|
@arturovt Hey, thanks for the PR. |
arturovt
force-pushed
the
fix/transloco-destroyed
branch
from
4396168 to
b139f86
Compare
|
I updated commit description. |
This avoids potential memory leaks and ensures correct behavior in reactive streams (e.g. switchMap) by returning EMPTY, which completes immediately. Use-case: - If load() is triggered via an observable (like within switchMap), and the service has already been destroyed (e.g. due to app shutdown, route unload, or SSR teardown), continuing execution would: - Create unnecessary subscriptions and pending async operations (like network calls). - Risk caching invalid/partial translation data. - In SSR, could retain memory or even leak state between requests. Returning EMPTY ensures the observable chain completes cleanly without side effects. Here’s a specific leak scenario this fix prevents: ```js componentLanguage$.pipe( switchMap(lang => translocoService.load(lang)), ).subscribe(); ```
arturovt
force-pushed
the
fix/transloco-destroyed
branch
from
b139f86 to
e31c6f7
Compare
|
@shaharkazaz I rebased, but ain't sure why CI may fail randomly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids potential memory leaks and ensures correct behavior in reactive streams
(e.g. switchMap) by returning EMPTY, which completes immediately.
Use-case:
has already been destroyed (e.g. due to app shutdown, route unload, or SSR teardown),
continuing execution would:
Returning EMPTY ensures the observable chain completes cleanly without side effects.
Here’s a specific leak scenario this fix prevents: