Skip to content

Conversation

@arturovt
Copy link
Contributor

@arturovt arturovt commented Feb 1, 2025

new expressions are not dropped by default, because they are considered side-effectful.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in StackBlitz

@jsverse/transloco

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco@833

@jsverse/transloco-locale

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-locale@833

@jsverse/transloco-messageformat

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-messageformat@833

@jsverse/transloco-optimize

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-optimize@833

@jsverse/transloco-persist-lang

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-persist-lang@833

@jsverse/transloco-persist-translations

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-persist-translations@833

@jsverse/transloco-preload-langs

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-preload-langs@833

@jsverse/transloco-schematics

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-schematics@833

@jsverse/transloco-scoped-libs

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-scoped-libs@833

@jsverse/transloco-utils

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-utils@833

@jsverse/transloco-validator

npm i https://pkg.pr.new/jsverse/transloco/@jsverse/transloco-validator@833

commit: fb8ef1f

@shaharkazaz
Copy link
Collaborator

@arturovt Tnx again for the PR!
Can you please update the PR, and I'll merge?

@arturovt arturovt force-pushed the refactor/tree-shake-tokens branch from d80eb8d to 93b30c3 Compare October 12, 2025 21:04
@shaharkazaz
Copy link
Collaborator

@arturovt Tnx!
Seems like there was a merge issue? looking at the CI failure messages

`new` expressions are not dropped by default, because they are considered side-effectful.
@arturovt arturovt force-pushed the refactor/tree-shake-tokens branch from 93b30c3 to fb8ef1f Compare October 13, 2025 14:31
@shaharkazaz shaharkazaz merged commit f3a7829 into jsverse:master Oct 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants