Skip to content

Conversation

@xDivisionByZerox
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The marker function does not support scopes.

Issue Number:

What is the new behavior?

The marker function does support scopes by supporting the workaround people have been using so far.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR supersedes #183.

While the original PR rewrote parts of the extraction algorithm, I tried to do as little as possible. This should ensure that the workaround people have been using does not break. While this would technically not be considered a breaking change, I'm sure that developers will be thankful for considering this "rolling release" of this feature.

If the maintainers decide that another implementation is more suitable, I'm more than happy to fulfil their requests and update the implementation in this PR.

Note

I did not update the documentation so far, as I'd like to have an opinion by a maintainer on the implementation first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant