feat: allow scope in marker function #238
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The marker function does not support scopes.
Issue Number:
What is the new behavior?
The marker function does support scopes by supporting the workaround people have been using so far.
Does this PR introduce a breaking change?
Other information
This PR supersedes #183.
While the original PR rewrote parts of the extraction algorithm, I tried to do as little as possible. This should ensure that the workaround people have been using does not break. While this would technically not be considered a breaking change, I'm sure that developers will be thankful for considering this "rolling release" of this feature.
If the maintainers decide that another implementation is more suitable, I'm more than happy to fulfil their requests and update the implementation in this PR.
Note
I did not update the documentation so far, as I'd like to have an opinion by a maintainer on the implementation first.