feat: support langs option in find command #139
Conversation
|
@kdraba Can you please update the branch with master so we can push this forward? 😃 |
…i_command_should_respect_langs_option # Conflicts: # src/keys-detective/compare-keys-to-files.ts
Done. |
| for (const [scope, path] of Object.entries(scopePaths)) { | ||
| const keys = scopeToKeys[scope]; | ||
| if (keys) { | ||
| if (keys && typeof path === 'string') { |
There was a problem hiding this comment.
Why is this needed? path is supposed to be a string
| export function findMissingKeys(inlineConfig: Config) { | ||
| const logger = getLogger(); | ||
| const config = resolveConfig(inlineConfig); | ||
| const config = resolveConfig({ langs:[], ...inlineConfig }); |
There was a problem hiding this comment.
The only thing is that this config property has 2 different purposes when running the find command and when running the extract.
we need to make it clear in the docs if we want to use the same property.
Also, the default config should be different based on what action you are running, otherwise, you need to override it locally like you did here but I'm not sure that's a good practice in the long run.
| filePath: string; | ||
| } | ||
|
|
||
| export function filterPathByLang( |
There was a problem hiding this comment.
Please add an explanation to why this was created and what is this used for
| `${res.baseFilesPath}/${isGlobal ? '' : scope}/*.${fileFormat}` | ||
| ), | ||
| ) | ||
| .filter(filterPathByLang(langsToProcess, scopeAndLangFromPathOption)), |
There was a problem hiding this comment.
Seems like you can create this filter once and use it across the function, generally speaking you can create it once with the command config no?
2 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #138 138
What is the new behavior?
The find command respects the langs option and only processes files for the specified languages. If the langs option is not present, all files will be processed.
Does this PR introduce a breaking change?
Usages of the find command, that specify languages using the langs option will behave differently. Instead of processing all existing file, only those files specified in the langs options will be processed.
Migration: If you want to process all files, remove the langs option from the find command invocation.
Other information