1.4.2 Gmail Inbox = null

[m1dst]

I just upgraded to 1.4.2 and found that I was getting a null exception when requesting the inbox.

var inbox = client.Inbox;
inbox.Open(FolderAccess.ReadWrite);

I rolled back to version 1.4.1 and it works as usual.

[jstedfast]

I can't seem to reproduce this with 1.4.2 and there have been no patches that I can find that would affect this between 1.4.1 and 1.4.2.

Do you have a test case I can use to reproduce this problem?

[m1dst]

Just tried the upgrade again and confirmed it still fails. It doesn't fail with a non Google IMAP though.

I will try to create something standalone to repro.

[m1dst]

OK, managed to repro the problem in a console app using the following code.

using (var client = new ImapClient())
{

    var host = "imap.gmail.com";
    var port = 993;
    var username = "";
    var password = "";

    client.Connect(host, port, true);
    client.Authenticate(username, password);

    var inbox = client.Inbox;
    inbox.Open(FolderAccess.ReadWrite);
}   

MailKit42GmailNullRepro.zip

Confirmed that 1.4.2 fails and 1.4.1 works.

What I did notice is I deliberately supplied an incorrect password and the authentication section passed silently in 1.4.2 but in 1.4.1 it warned of incorrect password.

So something has definitely changed.

James

[jstedfast]

Okay, so supplying an invalid password is broken now in that it doesn't properly emit an exception.

That sounds plausible because I did change some of that logic recently. I'll take a look.

[jstedfast]

Yep! Found and fixed the issue! Thanks for reporting. I'll try to push a new nuget release soon.

[m1dst]

I confirm it fixed my issue.

Thanks

On Tuesday, 16 August 2016, Jeffrey Stedfast notifications@github.com
wrote:

Yep! Found and fixed the issue! Thanks for reporting. I'll try to push a
new nuget release soon.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#383 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6h-NBxOKp-FG8yJjb_nTcwyoqtWjKTks5qga0UgaJpZM4JklCc
.