Lock opened file inodes to prevent a use after free race condition #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstaf
approved these changes
Aug 27, 2024
|
Looks great after reviewing! Thanks for your PR, I'll close your associated issue. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #414
There's a race condition where the opened file handlers are getting closed by the
Flushoperation:onedriver/fs/fs.go
Line 705 in 15a1c64
This PR moves the existed
inodelock prior to opening the file descriptor and wraps the same inode lock around the fd closure, which prevents the mentioned bug, and handles/reports the un-handled error.