Skip to content

fix: Fix an issue where dev dependencies weren't installed #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ieedan merged 1 commit into from
Dec 4, 2025
Merged

fix: Fix an issue where dev dependencies weren't installed #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/whole-fans-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"jsrepo": patch
---

fix: Fix an issue where dev dependencies weren't installed

47 changes: 33 additions & 14 deletions packages/jsrepo/src/utils/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,16 @@ export type ResolvedWantedItem = {
registry: ResolvedRegistry;
item: {
name: string;
description?: string;
add?: RegistryItemAdd;
description: string | undefined;
add: RegistryItemAdd | undefined;
type: RegistryItemType;
registryDependencies?: string[];
dependencies?: (RemoteDependency | string)[];
registryDependencies: string[] | undefined;
dependencies: (RemoteDependency | string)[] | undefined;
devDependencies: (RemoteDependency | string)[] | undefined;
files: Array<RepositoryOutputFile | DistributedOutputManifestFile>;
envVars: Record<string, string> | undefined;
categories: string[] | undefined;
meta: Record<string, string> | undefined;
};
};

Expand Down Expand Up @@ -239,26 +243,31 @@ export async function resolveWantedItems(

export type ResolvedItem = {
name: string;
description?: string;
add?: RegistryItemAdd;
description: string | undefined;
add: RegistryItemAdd | undefined;
type: RegistryItemType;
dependencies?: (RemoteDependency | string)[];
registryDependencies: string[] | undefined;
dependencies: (RemoteDependency | string)[] | undefined;
devDependencies: (RemoteDependency | string)[] | undefined;
registry: ResolvedRegistry;
files: Array<RepositoryOutputFile | DistributedOutputManifestFile>;
envVars: Record<string, string> | undefined;
categories: string[] | undefined;
meta: Record<string, string> | undefined;
};

export type ItemRepository = {
name: string;
type: RegistryItemType;
add?: RegistryItemAdd;
description?: string;
dependencies?: (RemoteDependency | string)[];
devDependencies?: (RemoteDependency | string)[];
add: RegistryItemAdd | undefined;
description: string | undefined;
dependencies: (RemoteDependency | string)[] | undefined;
devDependencies: (RemoteDependency | string)[] | undefined;
registry: ResolvedRegistry;
files: Array<RepositoryOutputFile & { content: string }>;
envVars?: Record<string, string>;
categories?: string[];
meta?: Record<string, string>;
envVars: Record<string, string> | undefined;
categories: string[] | undefined;
meta: Record<string, string> | undefined;
};

export type ItemDistributed = DistributedOutputItem & { registry: ResolvedRegistry };
Expand Down Expand Up @@ -335,8 +344,12 @@ async function fetchItemRepositoryMode(
add: item.add,
description: item.description,
dependencies: item.dependencies,
devDependencies: item.devDependencies,
registry: item.registry,
files: filesResult,
envVars: item.envVars,
categories: item.categories,
meta: item.meta,
});
}

Expand Down Expand Up @@ -643,10 +656,16 @@ export function resolveTree(
resolvedItems.set(wantedItem.item.name, {
name: wantedItem.item.name,
type: wantedItem.item.type,
description: wantedItem.item.description,
add: wantedItem.item.add,
registryDependencies: wantedItem.item.registryDependencies,
dependencies: wantedItem.item.dependencies,
devDependencies: wantedItem.item.devDependencies,
registry: wantedItem.registry,
files: wantedItem.item.files,
envVars: wantedItem.item.envVars,
categories: wantedItem.item.categories,
meta: wantedItem.item.meta,
});

const resolvedRegistryDependencies = resolveTree(needsResolving, {
Expand Down
Loading