-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add include files config option #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add include files config option #623
Conversation
🦋 Changeset detectedLatest commit: e1faadc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Thanks @EmericW this looks really good! Will give it a try when I have the chance. The only other concern I would have would be in adding |
|
Thanks for the quick review. I didn't realise what the |
|
|
ieedan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just fix the formatting and I will merge rn!
|
Thank you! |
This features allows you to include arbitrary static files into your registry as discussed here: #616
It works by adding a glob pattern referencing your desired files in your registry config under the
includeFilesproperty. If a matching file is found in any of your blocks that are directories, it will be added to the manifest.I currently don't have an automated test for the actual adding of the files to your directory. I have tested it manually and it does work out of the box, no changes where required to the add command. The setup to create this automated test seemed rather daunting.
As soon as this is approved i'll make a PR to document this feature as well.