-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSR #23
Support JSR #23
Conversation
WalkthroughThe project has been updated to include new badges for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .github/workflows/jsr.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- README.md (2 hunks)
- deno.jsonc (1 hunks)
Additional comments not posted (5)
.github/workflows/jsr.yml (1)
1-27
: Ensure thejsr:@david/publish-on-tag@0.1.3
script is compatible with the project's requirements for JSR support and that it adheres to security best practices.deno.jsonc (1)
3-5
: Confirm the version0.0.0
of@lambdalisue/async
is intended. Typically, a more stable version is used in production..github/workflows/test.yml (1)
41-43
: The addition of the "JSR publish (dry-run)" step is a good practice for safely testing the publish process. Ensure that this step is correctly integrated into the CI/CD pipeline and does not interfere with other steps.README.md (2)
3-4
: Ensure the URLs for thejsr
anddenoland
badges are correct and lead to the intended destinations. This helps users and contributors quickly assess the project's status and compatibility.
91-108
: The restructuring ofPromise.all
calls forrlock
andlock
methods appears to improve code readability and concurrency handling. Review the changes to ensure they align with the project's standards for asynchronous operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- README.md (2 hunks)
- queue.ts (1 hunks)
- stack.ts (1 hunks)
Additional comments not posted (4)
stack.ts (1)
1-1
: LGTM! ImportingWaitOptions
as a type is a good practice for tree shaking and reducing bundle size.queue.ts (1)
1-1
: LGTM! ImportingWaitOptions
as a type is consistent with best practices for optimizing the code.README.md (2)
3-4
: The addition ofjsr
anddenoland
badges enhances the documentation. Please ensure the URLs are correct and functional.
91-108
: Ensure the restructuring ofPromise.all
calls forrlock
andlock
methods maintains the intended logic and does not introduce side effects.
Summary by CodeRabbit
jsr
anddenoland
.Promise.all
calls forrlock
andlock
methods.