-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making stimulus-swipe-container drag with stimulus div #136
Making stimulus-swipe-container drag with stimulus div #136
Conversation
🦋 Changeset detectedLatest commit: a7fb39d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hello, can I please get this review? |
Sorry for the delay. Looks like a test is failing now. Maybe it just needs to be updated? |
I tested locally. I hope they pass now |
Hi @Emily-ejag It looks like there is one test that is failing sometimes in the simulation part of the code. This might be failing randomly due to different random data generation in the simulation data? |
@jodeleeuw, sorry for the delay on this PR. We've updated the PR to (hopefully) resolve that failing simulation. When you get a chance, could you approve the workflow so that we can verify that we've fixed the test? Thanks so much for your patience and help on this PR! |
Wow, thanks for the rapid response! |
The patch ensures that both the container (
#jspsych-html-swipe-response-stimulus-container
) and the stimulus (#jspsych-html-swipe-response-stimulus
) move together when dragged, providing a unified and seamless interaction.