Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making stimulus-swipe-container drag with stimulus div #136

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Aug 26, 2024

The patch ensures that both the container (#jspsych-html-swipe-response-stimulus-container) and the stimulus (#jspsych-html-swipe-response-stimulus) move together when dragged, providing a unified and seamless interaction.

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: a7fb39d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jspsych-contrib/plugin-html-swipe-response Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Emily-ejag
Copy link
Contributor Author

Hello, can I please get this review?

@jodeleeuw
Copy link
Member

Sorry for the delay. Looks like a test is failing now. Maybe it just needs to be updated?

@Emily-ejag
Copy link
Contributor Author

I tested locally. I hope they pass now

@jodeleeuw
Copy link
Member

Hi @Emily-ejag

It looks like there is one test that is failing sometimes in the simulation part of the code. This might be failing randomly due to different random data generation in the simulation data?

@richford
Copy link
Contributor

@jodeleeuw, sorry for the delay on this PR. We've updated the PR to (hopefully) resolve that failing simulation. When you get a chance, could you approve the workflow so that we can verify that we've fixed the test? Thanks so much for your patience and help on this PR!

@jodeleeuw jodeleeuw merged commit e09e80b into jspsych:main Jan 23, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
@richford richford deleted the add/swipe-response-stimulus-container-dragging branch January 23, 2025 21:26
@richford
Copy link
Contributor

Wow, thanks for the rapid response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants