chore(bolt): add option to skip fsync for test purposes (influxdata#1…

…9037)

bolt/kv.go

@@ -24,15 +24,33 @@ type KVStore struct {
 	path string
 	db   *bolt.DB
 	log  *zap.Logger
+
+	noSync bool
+}
+
+type KVOption func(*KVStore)
+
+// WithNoSync WARNING: this is useful for tests only
+// this skips fsyncing on every commit to improve
+// write performance in exchange for no guarantees
+// that the db will persist.
+func WithNoSync(s *KVStore) {
+	s.noSync = true
 }
 
 // NewKVStore returns an instance of KVStore with the file at
 // the provided path.
-func NewKVStore(log *zap.Logger, path string) *KVStore {
-	return &KVStore{
+func NewKVStore(log *zap.Logger, path string, opts ...KVOption) *KVStore {
+	store := &KVStore{
 		path: path,
 		log:  log,
 	}
+
+	for _, opt := range opts {
+		opt(store)
+	}
+
+	return store
 }
 
 // Open creates boltDB file it doesn't exists and opens it otherwise.
@@ -56,6 +74,8 @@ func (s *KVStore) Open(ctx context.Context) error {
 	}
 	s.db = db
 
+	db.NoSync = s.noSync
+
 	s.log.Info("Resources opened", zap.String("path", s.path))
 	return nil
 }

kv/kv_test.go

@@ -24,7 +24,9 @@ func NewTestBoltStore(t *testing.T) (kv.SchemaStore, func(), error) {
 	ctx := context.Background()
 	logger := zaptest.NewLogger(t)
 	path := f.Name()
-	s := bolt.NewKVStore(logger, path)
+
+	// skip fsync to improve test performance
+	s := bolt.NewKVStore(logger, path, bolt.WithNoSync)
 	if err := s.Open(context.Background()); err != nil {
 		return nil, nil, err
 	}

tenant/service_test.go

@@ -25,7 +25,7 @@ func NewTestBoltStore(t *testing.T) (kv.SchemaStore, func(), error) {
 	f.Close()
 
 	path := f.Name()
-	s := bolt.NewKVStore(zaptest.NewLogger(t), path)
+	s := bolt.NewKVStore(zaptest.NewLogger(t), path, bolt.WithNoSync)
 	if err := s.Open(context.Background()); err != nil {
 		return nil, nil, err
 	}