Allow to send / receive nlohman::json objects #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Closes #35 - purpose: this way we have more possibilities, e.g. seriazling from / to streams.
|
I checked other languages and libraries, apart from some custom Rust-based implementation on B2 (BackBlaze), almost noone does support this use case, people usually stick with JSON Lines - JSON RPC, meaing it's delimited by a new-line (and other new lines are disallowed). I'd suggest to close the pull-request, since you can already very easily implement that using your library, since otherwise we are just waking the complexity dragon for no good reason. Is it ok if I close the pull-request and the related issue? |
|
Sure, thanks for your effort anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibilities, e.g. seriazling from / to streams
This is a proposal, feel free to push / suggest changes as you require, etc.
Also if you don't want to merge it for some reason that's okay too.