Change gpa to score to better reflect variance in international scoring systems #391
Conversation
…international scoring systems
|
@stp-ip @thomasdavis can you have a look? I'd like to merge this asap. |
|
Codewise this looks good. Still not sure we should be merging in breaking changes until we know what our overall direction is. If we agree, that the v1 branch is breaking and currently open for development and open to future breaking changes until we do a release, I'm happy to get this in now and discuss other options later :) |
|
LGTM. We will have some breaking changes, but minimal. |
|
@stp-ip @thomasdavis as far as I'm concerned we can integrate breaking changes into the v1.0.0 branch. In the README we state that we adhere to the Semantic Versioning standard, and given that we haven't done an official (tagged) v1.0 release yet, breaking changes are fair game. |
|
@dandydev Very true. We also will be only affecting thousands, not millions, let's bear the cost for now. |
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #288, supersedes #328