Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json-schema.org/address# for location #113

Closed
wants to merge 1 commit into from

Conversation

madskristensen
Copy link

Instead of defining your own location type, why not use the one already specified on the official JSON Schema website?

Instead of defining your own `location` type, why not use the one already specified on the official JSON Schema website?
@ocram
Copy link
Contributor

ocram commented Jul 16, 2014

Is there any documentation for the http://json-schema.org/address# reference that shows why it may be preferable? I can't find any on the json-schema.org website.

@madskristensen
Copy link
Author

Not that I know of, but I can add it. I'm sending json-schema.org some pull requests to update their outdated v3 samples, so I might as well update the address schema with titles and descriptions too

@olivif
Copy link
Collaborator

olivif commented Dec 24, 2015

Hey @madskristensen, thanks for your contribution! This has been discussed in a couple of places and we will be going with the address schema for location, great suggestion! 😄

This will be a larger change though, as we have added the location field to more objects since the PR and have plans to add it to a few more (see #63). I am closing this for now as it needs more work and is out of date, but feel free to re-open if necessary.

@olivif olivif closed this Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants