Use mb_strlen instead of strlen when mbstring extension is available. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanagi
changed the title
Collaborator
|
👍 Great test character selection! |
Contributor
Author
|
Thanks 😊 |
justinrainbow
added a commit
that referenced
this pull request
Aug 25, 2014
Use mb_strlen instead of strlen when mbstring extension is available.
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Use mb_strlen instead of strlen when mbstring extension is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strlen() returns the number of bytes, not the number of characters.
This causes a problem when a multibyte string is supplied to string length validation.
mb_strlen() counts the number of characters, so is suitable for minLength/maxLength check.
I modified to use mb_strlen() when mbstring extension is loaded.