-
Notifications
You must be signed in to change notification settings - Fork 356
Upgrade test suite to use generators #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the test suite to use Generators instead of arrays in data providers while applying additional modernizations across test files. Key changes include:
- Converting test data provider methods to return Generator objects.
- Adding declare(strict_types=1) to all test files.
- Replacing string literals for class references with ::class constants.
- Removing outdated file header comments in favor of a centralized LICENSE.md.
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/ValidatorTest.php | Added strict_types declaration. |
tests/Uri/UriRetrieverTest.php | Updated mock creation to use ::class and added strict_types. |
tests/Uri/UriResolverTest.php | Added strict_types declaration. |
tests/Uri/Retrievers/* | Added strict_types and updated docblocks/license headers. |
tests/Constraints/* | Updated data provider methods to return Generator and adjusted JSON decoding to use object mode where needed. |
CHANGELOG.md | Updated changelog with a reference to the generator upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Generator
objects.LICENSE.md
at the rootdeclare(strict_types=1);
to all test files::class
constant.