Skip to content

Upgrade test suite to use generators #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 114 commits into from
Jun 24, 2025

Conversation

DannyvdSluijs
Copy link
Collaborator

This PR will:

  • Update all data providers to return Generator objects.
  • Remove file headers with a license reference in favour of the LICENSE.md at the root
  • Remove class docbocks which where defining unused attributes
  • Add declare(strict_types=1); to all test files
  • Replace class strings with their resp. ::class constant.
  • More updates bringing test files to PHP 7.2 level using rector

@DannyvdSluijs DannyvdSluijs requested a review from Copilot June 23, 2025 20:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the test suite to use Generators instead of arrays in data providers while applying additional modernizations across test files. Key changes include:

  • Converting test data provider methods to return Generator objects.
  • Adding declare(strict_types=1) to all test files.
  • Replacing string literals for class references with ::class constants.
  • Removing outdated file header comments in favor of a centralized LICENSE.md.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/ValidatorTest.php Added strict_types declaration.
tests/Uri/UriRetrieverTest.php Updated mock creation to use ::class and added strict_types.
tests/Uri/UriResolverTest.php Added strict_types declaration.
tests/Uri/Retrievers/* Added strict_types and updated docblocks/license headers.
tests/Constraints/* Updated data provider methods to return Generator and adjusted JSON decoding to use object mode where needed.
CHANGELOG.md Updated changelog with a reference to the generator upgrade.

@DannyvdSluijs DannyvdSluijs merged commit 4118460 into master Jun 24, 2025
16 checks passed
@DannyvdSluijs DannyvdSluijs deleted the upgrade-test-suite-to-use-generators branch June 24, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant