Implement $ref compliance #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compliance. This makes public interface breaking changes. Change RefResolver so that we can actually resolve recursive references properly Get most of the draft4 tests working (only 2 errors now) Create a better pointer resolver Now refs are draft4 compliant, getting unit tests to pass again for refresolver Fix up UriResolver unit tests Sort out UriRetriever unit test issues Make sure to set the id property too
Collaborator
Author
|
This was forked off @araines branch. Do you mean I should open the PR at https://github.com/araines/json-schema instead of here at https://github.com/justinrainbow/json-schema ? |
Collaborator
|
Correct. That will allow your work to come in on the open PR. Otherwise, your open PR would be bringing in his work and I think he is still making adjustments. I would prefer you work together on that branch of changes. Make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some tests to #210
These tests shows that there are still work do be done to make this code work.