Skip to content

Conversation

@mathroc
Copy link
Contributor

@mathroc mathroc commented Jan 14, 2016

improve a few case resolving $refs

not done as well as #210 but does not introduce BC so it could be useful before having a new major version

@bighappyface
Copy link
Collaborator

Hey @mathroc thanks for the contribution! While I understand the value in continuing to improve RefResolver while maintaining backward compatibility, I think we are better served by focusing on #210 and giving this package a shot at a comprehensive fix, even if that means a major version bump.

May @araines and I have your assistance reviewing #210 to ensure it is ready to rock so that I can proceed with the next version? I very much value your work here and want to try to get your help while you are willing to give it to help this package move in the right direction sooner rather than later.

@mathroc
Copy link
Contributor Author

mathroc commented Jan 14, 2016

@bighappyface I understand, it's just that made thoses changes before seeing #210 and submitted this in case you'd rather not have a major version immediately. I'm actually using @araines fork and my use cases are also working with his PR :)
I'm gooing to take a closer look at #210 and will tell you if I have comments

(closing this one then)

@mathroc mathroc closed this Jan 14, 2016
@bighappyface
Copy link
Collaborator

@mathroc 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants