Check for duplicate test names #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
force-pushed
the
duplicate-test-names
branch
from
d8db613 to
54e80d6
Compare
|
Can you split the changes so that we can see the build fail? Put the name check on the first commit, and let it build. Then come back and fix the test names, which should let the build pass. |
f3ath
reviewed
Aug 4, 2024
f3ath
reviewed
Aug 4, 2024
f3ath
reviewed
Aug 4, 2024
f3ath
reviewed
Aug 4, 2024
f3ath
reviewed
Aug 4, 2024
|
The build script may soon require its own test suite... |
Marcono1234
force-pushed
the
duplicate-test-names
branch
from
54e80d6 to
8ee5d97
Compare
|
Have split it into two commits now: The build for the first commit failed, as desired. And the second commit fixed it. I hope the changes are ok like this now. Please let me know if you want anything else changed. |
|
Hmm... @Marcono1234 / @f3ath I accidently merged this. Meant to approve instead and wait for @f3ath's responses. Please open a new PR for any additional changes. |
|
The changes look fine to me actually. I think we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #36 (comment)
Due to copy & paste errors there were already duplicate names in
selectors.json, see changes below.Not sure if the change in
build.jsclean enough, please let me know if I should change it in some way.