Add test for non-escaped U+007F (DEL control character) #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good. I'll approve once the conflicts are resolved. |
Marcono1234
force-pushed
the
non-escaped-del
branch
from
51dc7dc to
1585453
Compare
|
Sorry, have resolved the conflict now. |
f3ath
approved these changes
Aug 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSONPath specification says only the control characters 0x00 to 0x1F must be escaped (same as for JSON). The control character 0x7F (DEL) does not have to be escaped.
However, some JSON libraries are too strict and reject a non-escaped 0x7F, see also nst/JSONTestSuite#118.
Therefore this test makes sure JSONPath implementations don't make the same error.