Skip to content

Conversation

gregsdennis
Copy link
Collaborator

Copy link
Collaborator

@f3ath f3ath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass on my implementation. Any reason why these tests are negative? Seems like adding a positive match would also check that the escaped chars are not missed/mishandled.

@gregsdennis
Copy link
Collaborator Author

Any reason why these tests are negative?

Nope. Just forgot to update the data. Will do in a bit (probably tomorrow).

@gregsdennis
Copy link
Collaborator Author

@f3ath I've made some actual data to query.

@f3ath f3ath merged commit 0ddbb76 into main May 16, 2024
@f3ath
Copy link
Collaborator

f3ath commented May 16, 2024

Looks good!

@gregsdennis gregsdennis deleted the gregsdennis/quote-escapes-in-expressions branch May 16, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants