Add filter tests for valid non-singular segment #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
changed the title
gregsdennis
approved these changes
Mar 24, 2024
jg-rp
reviewed
Mar 25, 2024
|
Have corrected the typo in the test names and squashed all changes into a single commit again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I have overlooked something, the existing tests (code in the lines below my changes) was only covering invalid non-singular filters.
These tests also make sure that for example
?@[0, 0, 'a']does not cause the result to contain duplicate values (despite the duplicate0)?@[0:2]does not truncate the result if the array has more elements