Add upper/lower presentation format for am/pm in fromMillis #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Woodgate <ajwoodgate@gmail.com>
mattbaileyuk
approved these changes
Aug 10, 2023
Member
mattbaileyuk
left a comment
mattbaileyuk
left a comment
There was a problem hiding this comment.
Thanks for contributing this fix. There's probably more iterative work on some of these picture notations, but good to get this one ticked off.
This was referenced Sep 28, 2023
renovate bot
referenced
this pull request
in solid-design-system/solid
Mar 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsonata](http://jsonata.org/) ([source](https://togithub.com/jsonata-js/jsonata)) | [`2.0.3` -> `2.0.4`](https://renovatebot.com/diffs/npm/jsonata/2.0.3/2.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsonata-js/jsonata (jsonata)</summary> ### [`v2.0.4`](https://togithub.com/jsonata-js/jsonata/blob/HEAD/CHANGELOG.md#204-Maintenance-Release) [Compare Source](https://togithub.com/jsonata-js/jsonata/compare/v2.0.3...v2.0.4) - Prevent writing to the object prototype or constructor (PR [https://github.com/jsonata-js/jsonata/pull/676](https://togithub.com/jsonata-js/jsonata/pull/676)) - Add upper/lower presentation format for am/pm in fromMillis (PR [https://github.com/jsonata-js/jsonata/pull/644](https://togithub.com/jsonata-js/jsonata/pull/644)) - Various documentation additions and corrections </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone Europe/Berlin, Automerge - "after 10pm every weekday,before 5am every weekday" in timezone Europe/Berlin. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/solid-design-system/solid). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574
Updates $fromMillis() function to support am/pm
PNpresentation format to output AM/PM and adds test cases forPNandPn(existing test case for default presentation covers justP).Note: I did not implement [PNn] for Am/Pm, it's not shown in the examples https://www.w3.org/TR/xpath-functions-31/#date-time-examples so I assumed it's not commonly used and did not implement it to keep the fix simple. Happy to revisit that if needed.
Signed-off-by: Alex Woodgate ajwoodgate@gmail.com