Skip to content

fix(type): fix return type of evaluate method #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattbaileyuk merged 1 commit into from
Jan 18, 2023
Merged

fix(type): fix return type of evaluate method #615

mattbaileyuk merged 1 commit into from
Jan 18, 2023

Conversation

@tada5hi
Copy link
Contributor

@tada5hi tada5hi commented Jan 18, 2023 •
edited
Loading

mattbaileyuk
mattbaileyuk approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mattbaileyuk mattbaileyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, and I believe reflects the 2.0.0 change to evaluate(); thanks for the PR 👍

@mattbaileyuk mattbaileyuk merged commit 9ccb998 into jsonata-js:master Jan 18, 2023
@tada5hi
Copy link
Contributor Author

tada5hi commented Jan 18, 2023

your welcome 😊

@tlakomy tlakomy mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbaileyuk mattbaileyuk mattbaileyuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tada5hi @mattbaileyuk