fix test suite to work in all timezones #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>
mattbaileyuk
approved these changes
Feb 4, 2020
Member
|
Note: This isn't just a testsuite update, but could change the output of time functions in certain circumstances, but will now achieved the intended outcome. |
Member
Author
|
Correct, it doesn't change the tests at all. It fixes the code that causes the tests to fail in certain timezones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite failures are caused by careless use of non-UTC Date functions in the date/time parser
resolves #403
Signed-off-by: andrew-coleman andrew_coleman@uk.ibm.com