Skip to content

allow leading zeros when casting string to number #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattbaileyuk merged 1 commit into from
Oct 1, 2019
Merged

allow leading zeros when casting string to number #373

mattbaileyuk merged 1 commit into from
Oct 1, 2019

Conversation

@andrew-coleman
Copy link
Member

@andrew-coleman andrew-coleman commented Oct 1, 2019

Allow numeric strings to have leading zeros when casting to numbers in $number()
resolves #368

@coveralls
Copy link

coveralls commented Oct 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling c49b009 on zeros into 33d7940 on master.

@mattbaileyuk mattbaileyuk merged commit 290986a into master Oct 1, 2019
@mattbaileyuk mattbaileyuk deleted the zeros branch October 1, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbaileyuk mattbaileyuk mattbaileyuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Allow $number() to handle strings with leading '0' characters

4 participants

@andrew-coleman @coveralls @mattbaileyuk