Enhance $reduce to support 4 arg function #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbaileyuk
reviewed
Sep 4, 2019
| "D3030": "Unable to cast value to a number: {{value}}", | ||
| "D3040": "Third argument of match function must evaluate to a positive number", | ||
| "D3050": "First argument of reduce function must be a function with two arguments", | ||
| "D3050": "The second argument of reduce function must be a function with at least two arguments", |
Member
There was a problem hiding this comment.
Was curious about this change then realised that this was already wrong, and it should have said the second argument anyway.
mattbaileyuk
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second argument can now be an arity-4 function with the following signature
myfunc($accumulator, $value[, $index[, $array]])resolves #102