Skip to content

Conversation

@jhorbulyk
Copy link
Contributor

As discussed in #103

@coveralls
Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 4897027 on elasticio:add-uri-helper-functions into 00d36d0 on jsonata-js:master.

Copy link
Member

@andrew-coleman andrew-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jacob, I note from the Mozilla docs that these functions could throw a URIError for malformed URI sequences. Please could you catch these an re-throw a jsonata error code? This helps maintain conformance across different jsonata implementations (Java & Go that I know of). Thanks!

@jhorbulyk
Copy link
Contributor Author

@andrew-coleman Do you have any preference for one single jsonata error code or should I add an error code for each of the 4 functions?

@andrew-coleman
Copy link
Member

One error code is fine. You could add the function name as an insert into that error. Thanks.

@jhorbulyk
Copy link
Contributor Author

@andrew-coleman Updated.

@andrew-coleman andrew-coleman merged commit 0d0fa7b into jsonata-js:master Aug 29, 2019
@jhorbulyk jhorbulyk deleted the add-uri-helper-functions branch August 29, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants