Skip to content

Conversation

@asfordmatt
Copy link
Contributor

Fixes #105

Signed-off-by: Matt Chapman mpchapman@gmail.com

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3975564 on asfordmatt:master into 6c5ac50 on jsonata-js:master.

@mattbaileyuk
Copy link
Member

While I don't believe module is officially part of the npm spec for package.json it looks like it's getting enough use in the likes of Webpack and rollup to be worth including here to specify an ES6+ version.

However, I am a bit concerned about switching the default for main from the native ES6 code to the transpiled ES5 version, which was intentionally avoided when that version was introduced, but it might be time to revisit that. I'm mainly concerned about what that means for projects which import JSONata, in particular those like node-RED which use require('jsonata').

@mattbaileyuk
Copy link
Member

Thinking about this more, I'm not as concerned about that change as I was previously, and think this would be good to have as I'm such other people picking this up for their front-end projects, whether they're using Webpack or otherwise, are likely to run into this.

@coveralls
Copy link

coveralls commented Jan 16, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling fd7af99 on asfordmatt:master into dd3fe66 on jsonata-js:master.

@mattbaileyuk mattbaileyuk merged commit 6ae9d5b into jsonata-js:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants