Skip to content

Consider having the renderer decide on success/error with status code. #61

Open

Description

@beauby

Instead of having render jsonapi: foo and render jsonapi_errors: errors, simply have render jsonapi: foo and render jsonapi: errors, status: 400.

Activity

  1. nuheluxulu commented on Jun 7, 2019

    @nuheluxulu

    Thanks for this comment.
    Solved it as follows:

    #controllers/api/v1/api_controller.rb

    class ApiController < ApplicationController
      include ExceptionHandler
    end
    

    #controllers/api/v1/concerns/ExceptionHandler.rb

    module ExceptionHandler
      # provides the more graceful `included` method
      extend ActiveSupport::Concern
      included do
        rescue_from Exception do |exception|
          case exception
          when ActiveRecord::RecordNotFound
            render jsonapi_errors: {message: exception.message}, status: :not_found
          when ActiveRecord::RecordInvalid
            render jsonapi_errors: {message: exception.message}, status: :unprocessable_entity
          # else
            # figure out how to render_500
          end
        end
      end
    end
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions