-
-
Notifications
You must be signed in to change notification settings - Fork 320
add sponsors logo #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sponsors logo #1878
Conversation
|
Hi @Honyii! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hi @Honyii! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hey @Honyii , I checked your PR deployment errors. And I would like to suggest the way to resolve it. For build preview deployment error, you have to resolve this below error in the For CI/CD quality check error, you have to correct the linting check in the below given lines. For PR body validation, I think you missed some required information and kind of change of description in the code. I hope this would help you to pass all the checks. |
|
Hi @Honyii! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
|
Hi @Honyii! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Honyii! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Thanks a lot @jagpreetrahi ! |
pages/index.page.tsx
Outdated
| </section> | ||
|
|
||
| {/* Media Partner for JSON Schema conference */} | ||
| <section className='my-20'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Honyii 👋🏻, the new changes look awesome, great work! 🙌🏻
I just had a small suggestion:
- Maybe we could reduce the spacing from my-20 to my-18, as there seems to be a bit of extra space right now (as highlighted in the image).
pages/index.page.tsx
Outdated
| {/* Media Partner for JSON Schema conference */} | ||
| <section className='my-20'> | ||
| <div className='text-center mb-12'> | ||
| <h2 className='text-h3mobile md:text-h3 font-semibold mb-2'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- to keep consistency in dark mode, the heading should use 'dark: text-slate-200' color.
pages/index.page.tsx
Outdated
| <h2 className='text-h3mobile md:text-h3 font-semibold mb-2'> | ||
| Media Partner | ||
| </h2> | ||
| <p className='px-12 mx-auto md:w-3/4 md:mx-auto'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For paragraph, we should use 'dark: text-slate-300' color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Utkarsh-123github thanks for checking my pr and the suggestions given. I have updated the color and for the classname, there is no my-18 so I used my-16 for this. Kindly let me know if it's okay- i am happy to reiterate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Utkarsh-123github kindly do not merge yet - I have one more logo for a sponsor i need to add. This came up last minute.
pages/index.page.tsx
Outdated
| <br /> | ||
| </p> | ||
| </div> | ||
| <div className='flex flex-col items-center md:flex-row justify-center text-center gap-x-14 gap-y-4'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Honyii , here just give a 'mb-12' and then we are good to proceed🚀
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
What kind of change does this PR introduce?
Feature — Adds conference sponsors and media partner logo to the website
Issue Number:
Summary
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.