Skip to content

Conversation

@Honyii
Copy link
Contributor

@Honyii Honyii commented Oct 31, 2025

What kind of change does this PR introduce?

Feature — Adds conference sponsors and media partner logo to the website

Issue Number:

Summary

  • This pr adds the logo of JSOn Schema conference sponsors and media partner 2025 to the webpage

Does this PR introduce a breaking change?

No

Checklist
Please ensure the following tasks are completed before submitting this pull request.

@Honyii Honyii requested a review from a team as a code owner October 31, 2025 10:14
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Oct 31, 2025
@github-actions
Copy link

Hi @Honyii! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @Honyii! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@jagpreetrahi
Copy link
Contributor

jagpreetrahi commented Nov 1, 2025

Hey @Honyii , I checked your PR deployment errors. And I would like to suggest the way to resolve it.

For build preview deployment error, you have to resolve this below error in the page index file that are related to the prettier.

./pages/index.page.tsx
143:68  Error: Insert `;`  prettier/prettier
163:65  Error: Insert `;`  prettier/prettier
886:17  Error: Replace `⏎················href='https://dottxt.ai/'⏎················target='_blank'⏎················rel='noreferrer'⏎··············` with `·href='https://dottxt.ai/'·target='_blank'·rel='noreferrer'`  prettier/prettier
891:21  Error: Replace `⏎··················src={dottxt_logo}⏎··················className='·w-44'⏎··················alt='dottxt·logo'⏎···············` with `·src={dottxt_logo}·className='·w-44'·alt='dottxt·logo'`  prettier/prettier
897:1  Error: Delete `·`  prettier/prettier
897:1  Error: Expected indentation of 14 spaces but found 15.  indent
934:1  Error: Insert `········`  prettier/prettier
934:1  Error: Expected indentation of 8 spaces but found 0.  indent
935:1  Error: Insert `··`  prettier/prettier
935:1  Error: Expected indentation of 8 spaces but found 6.  indent
941:73  Error: Replace `·platform·connecting·tech·communities·with·over·250k·monthly·visitors,·⏎··············helping·speakers,·organizers,·and·attendees·discover·and` with `⏎··············platform·connecting·tech·communities·with·over·250k·monthly⏎··············visitors,·helping·speakers,·organizers,·and·attendees·discover·and⏎·············`  prettier/prettier
959:17  Error: Delete `⏎············`  prettier/prettier

For CI/CD quality check error, you have to correct the linting check in the below given lines.

  143:68  error  Insert `;`                                                                                                                                                                                                                                                                                                                                 prettier/prettier
  163:65  error  Insert `;`                                                                                                                                                                                                                                                                                                                                 prettier/prettier
  886:17  error  Replace `⏎················href='https://dottxt.ai/'⏎················target='_blank'⏎················rel='noreferrer'⏎··············` with `·href='https://dottxt.ai/'·target='_blank'·rel='noreferrer'`                                                                                                                                    prettier/prettier
  891:21  error  Replace `⏎··················src={dottxt_logo}⏎··················className='·w-44'⏎··················alt='dottxt·logo'⏎···············` with `·src={dottxt_logo}·className='·w-44'·alt='dottxt·logo'`                                                                                                                                       prettier/prettier
  897:1   error  Delete `·`                                                                                                                                                                                                                                                                                                                                 prettier/prettier
  897:1   error  Expected indentation of 14 spaces but found 15                                                                                                                                                                                                                                                                                             indent
  934:1   error  Insert `········`                                                                                                                                                                                                                                                                                                                          prettier/prettier
  934:1   error  Expected indentation of 8 spaces but found 0                                                                                                                                                                                                                                                                                               indent
  935:1   error  Insert `··`                                                                                                                                                                                                                                                                                                                                prettier/prettier
  935:1   error  Expected indentation of 8 spaces but found 6                                                                                                                                                                                                                                                                                               indent
  941:73  error  Replace `·platform·connecting·tech·communities·with·over·250k·monthly·visitors,·⏎··············helping·speakers,·organizers,·and·attendees·discover·and` with `⏎··············platform·connecting·tech·communities·with·over·250k·monthly⏎··············visitors,·helping·speakers,·organizers,·and·attendees·discover·and⏎·············`  prettier/prettier
  959:17  error  Delete `⏎············`                                                                                                                                                                                                                                                                                                                     prettier/prettier

For PR body validation, I think you missed some required information and kind of change of description in the code.
Like as ${missingItemsList}
Please update the PR description to include this information.

I hope this would help you to pass all the checks.
Thanks

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @Honyii! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @Honyii! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview c40a477

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4e1e90a) to head (c40a477).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @Honyii! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@Honyii
Copy link
Contributor Author

Honyii commented Nov 3, 2025

Thanks a lot @jagpreetrahi !

</section>

{/* Media Partner for JSON Schema conference */}
<section className='my-20'>
Copy link
Member

@Utkarsh-123github Utkarsh-123github Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hi @Honyii 👋🏻, the new changes look awesome, great work! 🙌🏻
I just had a small suggestion:

  • Maybe we could reduce the spacing from my-20 to my-18, as there seems to be a bit of extra space right now (as highlighted in the image).

{/* Media Partner for JSON Schema conference */}
<section className='my-20'>
<div className='text-center mb-12'>
<h2 className='text-h3mobile md:text-h3 font-semibold mb-2'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • to keep consistency in dark mode, the heading should use 'dark: text-slate-200' color.

<h2 className='text-h3mobile md:text-h3 font-semibold mb-2'>
Media Partner
</h2>
<p className='px-12 mx-auto md:w-3/4 md:mx-auto'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For paragraph, we should use 'dark: text-slate-300' color.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Utkarsh-123github thanks for checking my pr and the suggestions given. I have updated the color and for the classname, there is no my-18 so I used my-16 for this. Kindly let me know if it's okay- i am happy to reiterate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Utkarsh-123github kindly do not merge yet - I have one more logo for a sponsor i need to add. This came up last minute.

@github-project-automation github-project-automation bot moved this from Ready to review to Changes requested in PR - Triage Group Nov 3, 2025
<br />
</p>
</div>
<div className='flex flex-col items-center md:flex-row justify-center text-center gap-x-14 gap-y-4'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Honyii , here just give a 'mb-12' and then we are good to proceed🚀
Thank you!

@Utkarsh-123github Utkarsh-123github self-requested a review November 5, 2025 07:50
Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@Utkarsh-123github Utkarsh-123github merged commit 1ca4a48 into json-schema-org:main Nov 5, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Changes requested to Done in PR - Triage Group Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add 2025 conference sponsors and media partner to homepage

3 participants