Skip to content

Migrate NavigationButton, DocsHelp, and Card components to ShadCN #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 28, 2025

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jun 20, 2025

What kind of change does this PR introduce?

  • Adapted 3 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 3 components to ensure reliability and behavior coverage.
  • While adapting the components, utilized ShadCN's Button ,textarea ,card and separator elements.

Issue Number:

Screenshots/videos:

Screen.Recording.2025-06-20.190951.mp4

The Card and DocsHelp components looks exactly the same after migration to ShadCN.

Summary

This PR:

  • Migrated the existing NavigationButton.tsx, DocsHelp.tsx, and Card components to the ShadCN library.
  • Enhanced the styling of the NavigationButton component (added hover effect to the text size)
  • Added Cypress tests for all implemented components to ensure reliability and behavior coverage.

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 20, 2025 16:12
@idanidan29 idanidan29 added the GSoC Google Summer of Code related label Jun 20, 2025
Copy link

github-actions bot commented Jun 20, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6c828a5

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7e78fe8). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #1727   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        29           
  Lines           ?       548           
  Branches        ?       158           
========================================
  Hits            ?       548           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but there is a small problem with the thumbsdwon icon of the docshelp component as it os not turning red when clicking it.

Current
Screenshot 2025-06-27 at 14 35 26

Expected
Screenshot 2025-06-27 at 14 35 33

@idanidan29
Copy link
Collaborator Author

@benjagm I've adjusted according to your review this should be fixed now

@idanidan29 idanidan29 requested a review from benjagm June 27, 2025 17:21
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit d585a99 into json-schema-org:main Jun 28, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Jun 28, 2025
@idanidan29 idanidan29 deleted the phase-2.1 branch June 28, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants