generated from json-schema-org/repo-template
-
-
Couldn't load subscription status.
- Fork 56
Setup Turbopack for development #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aashish-Jha-11
wants to merge
1
commit into
json-schema-org:main
Choose a base branch
from
Aashish-Jha-11:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Turbopack Setup for JSON Schema Tour | ||
|
|
||
| This document explains the Turbopack configuration for faster development builds. | ||
|
|
||
| ## What was changed | ||
|
|
||
| 1. **Updated `next.config.mjs`** to include Turbopack configuration: | ||
| - Added experimental Turbopack rules for MDX processing | ||
| - Configured path aliases for better module resolution | ||
| - Maintained compatibility with existing MDX setup | ||
|
|
||
| 2. **Updated `package.json`** with new scripts: | ||
| - `next-dev-turbo`: Runs Next.js with the `--turbo` flag | ||
| - `dev:turbo`: Runs both Turbopack dev server and content watching concurrently | ||
|
|
||
| ## Usage | ||
|
|
||
| To use Turbopack for development: | ||
|
|
||
| ```bash | ||
| # Run with Turbopack (faster builds) | ||
| pnpm run dev:turbo | ||
|
|
||
| # Or just the Next.js server with Turbopack | ||
| pnpm run next-dev-turbo | ||
| ``` | ||
|
|
||
| To use the regular Webpack build: | ||
| ```bash | ||
| # Regular development (slower builds) | ||
| pnpm run dev | ||
| ``` | ||
|
|
||
| ## Hydration Issues Fixed | ||
|
|
||
| The following hydration issues were resolved for Turbopack compatibility: | ||
|
|
||
| 1. **IconLink Component**: Added proper SSR handling for `window.matchMedia` | ||
| 2. **Chakra UI Theme**: Disabled `useSystemColorMode` to prevent color mode mismatches | ||
| 3. **ContinueBtn Component**: Added hydration-safe localStorage access | ||
| 4. **Monaco Editor**: Used dynamic import with `ssr: false` to prevent DOM mismatches | ||
|
|
||
| ## Known Warnings | ||
|
|
||
| You may see this warning when using Turbopack: | ||
| ``` | ||
| ⚠ ./lib/server-functions.ts:28:23 | ||
| lint TP1004 fs.readFileSync(???*0*, "utf-8") is very dynamic | ||
| ``` | ||
|
|
||
| This is expected and doesn't affect functionality. It's related to dynamic file system operations in the server-side code generation functions. | ||
|
|
||
| ## Benefits | ||
|
|
||
| - **Faster builds**: Turbopack provides significantly faster build times compared to Webpack | ||
| - **Better development experience**: Hot reload and incremental compilation are faster | ||
| - **Full compatibility**: All existing features work including MDX processing, content watching, and hot module replacement | ||
|
|
||
| ## Configuration Details | ||
|
|
||
| The Turbopack configuration in `next.config.mjs`: | ||
| - Handles `.mdx` files with the `@mdx-js/loader` | ||
| - Provides path aliases for module resolution | ||
| - Maintains compatibility with the existing MDX and React setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this