Skip to content

Added new if-then-else example (Closes #71) #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

RoaaFouda
Copy link
Contributor

What kind of change does this PR introduce?

  • New documentation.

Issue Number:

If relevant, did you update the documentation?
No

Summary
I added a new example in the conditionals section that demonstrates the use of the minimum and not keywords with if-then-else. As mentioned in #71, this example was needed to provide more depth, as the existing examples primarily relied on constants. I would appreciate any feedback or suggestions for improvements to make this example even better.

Does this PR introduce a breaking change?

  • No

@erosb
Copy link
Collaborator

erosb commented Mar 11, 2025

Hello @RoaaFouda , thank you for raising the PR. I personally like it, for me it is a complex-enough demonstration of if-then-else, but not overly complex.

@JeelRajodiya @sandrina-p can you please take a look at it as well?

@RoaaFouda
Copy link
Contributor Author

Hi @erosb, I'm glad to hear that :)
I'm waiting for any additional feedback from @JeelRajodiya and @sandrina-p in case any changes are needed.

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Mar 13, 2025

@RoaaFouda thanks for the PR, the new lesson looks great! We are merging it.

@JeelRajodiya JeelRajodiya merged commit f03581e into json-schema-org:main Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a task showing usage of if with nontrivial schema
3 participants