Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate schema loading sections #857

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

handrews
Copy link
Contributor

We are adding a section dealing with loading, processing,
and referencing schemas.

These sections have been moved without any changes to text or
formatting beyond adjusting the indentation to fit the new
location.

This is the first step for #849.

We are adding a section dealing with loading, processing,
and referencing schemas.

These sections have been moved without any changes to text or
formatting beyond adjusting the indentation to fit the new
location.
@handrews
Copy link
Contributor Author

@gregsdennis @johandorland @Julian tagging y'all in as implementors to see if this direction makes sense. See #849 for context- this PR is just moving blocks around unchanged so if possible I'd like to get it merged quickly so I can put up actual real changes for longer review.

@Julian
Copy link
Member

Julian commented Feb 11, 2020

The outline in #849 certainly seems to make sense to me if I understand it (which there's always a chance I don't when dereferencing is involved). So +1 on this one I think?

@gregsdennis
Copy link
Member

These seem like the appropriate sections. Lift-and-shift doesn't concern me so much as the changes that'll come later to make it read a bit more fluently (to suggest that these parts are supposed to be together).

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff master handrews/load --color-moved --color-moved-ws=allow-indentation-change
All changes are moves. Good to go.

@Relequestual
Copy link
Member

We shouldn't worry about xml2rfc complaining about figure length as the resuling text document does the right thing when wrapping.

@Relequestual Relequestual merged commit 56b45de into json-schema-org:master Feb 12, 2020
@handrews
Copy link
Contributor Author

@Relequestual yeah the length warnings are not new.

@Julian I ended up including the part on dereferencing in the new section because the question of how to resolve references is closely related to the question of what it means to "load" a schema so that you have it available to reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants