Name the split "dependencies" to "dependent*" #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon further discussion, the grammatical approach that is most intuitive was deemed to be that the string array or schema's usage is dependent upon the presence or absence of the instance property. In at least some anecdotal reports, the nature and direction of the "dependencies" concept proved confusing. Others found it intuitive. The revised wording aims to explicitly tie the dependency direction to the naming convention. In addition, while there was some debate over the most migration-friendly strategy, the decision is to leave the old form of "dependencies" available as an extension, and for at least one draft use the meta-schema to avoid its redefinition. Therefore both keywords resulting from the split have been renamed. "dependentSchemas" was also in the wrong section. As an in-place conditional applicator, it belongs with "if", "then", and "else". Not with the object child applicators. Apparently, I had not made the meta-schema changes at all. The "$comment" follows the precedent established from leaving "definitions" in the meta-schema after the rename to "$defs".
dlax
approved these changes
Jun 21, 2018
philsturgeon
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon further discussion in #591 (comment), the grammatical
approach that is most intuitive was deemed to be that the
string array or schema's usage is dependent upon the presence
or absence of the instance property.
In at least some anecdotal reports, the nature and
direction of the "dependencies" concept proved confusing.
Others found it intuitive. The revised wording aims
to explicitly tie the dependency direction to the
naming convention.
In addition, while there was some debate over the most
migration-friendly strategy, the decision is to leave
the old form of "dependencies" available as an extension,
and for at least one draft use the meta-schema to avoid
its redefinition. Therefore both keywords resulting
from the split have been renamed.
"dependentSchemas" was also in the wrong section. As an
in-place conditional applicator, it belongs with "if", "then",
and "else". Not with the object child applicators.
Apparently, I had not made the meta-schema changes at all.
The "$comment" follows the precedent established from leaving
"definitions" in the meta-schema after the rename to "$defs".