Remove leftover wording from preprocessing, restore limitation note #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed the preprocessing rules, including those related to using the entire instance value, and made a note of the limitation and intent to remove it in a future draft. This stray phrase should have been removed at that time. Also add a cref acknowledging the limitations and further work needed in this area. There was such a cref in the previous draft and I had thought I'd updated it rather than deleting it, but apparently not. It was a good idea, let's keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the preprocessing rules, including those related to
using the entire instance value, and made a note of the limitation
and intent to remove it in a future draft.
This stray phrase should have been removed at that time.
Also add a cref acknowledging the limitations and further work
needed in this area. There was such a cref in the previous
draft and I had thought I'd updated it rather than deleting it,
but apparently not. It was a good idea, let's keep it.