Skip to content

Conversation

@awwright
Copy link
Member

@awwright awwright commented Feb 5, 2017

This revision is intended to simplify/clarify the behavior for the definitions of several keywords. It removes references to "child validation" which is undefined and not any special kind of validation. It reworks the properties/patternProperties definitions to simplify language regarding which instances are processed/applied against which schemas.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm fine with finding a phrase more suitable than "child validation" (which is really just intended to mean "validation of children according to the regular process" not "special process that involves children"), I am generally opposed to this.

The process of selecting subschemas for application to child instances is critically important to the function of JSON Schema as a whole (I still think it belongs in core, honestly), and is very different, implementation-wise, from immediate validation keywords.

Whatever problem you see here (and aside from not liking the two words "child validation", I can't figure out what that problem is supposed to be), this is not the right fix.

@awwright
Copy link
Member Author

awwright commented Feb 5, 2017

@handrews I'm really not sure which distinction you're making, can you elaborate some?

If we want to make it clear which parts of the keyword value are applied/mapped to which instances, well, we just have to describe how that works.

@handrews
Copy link
Contributor

handrews commented Feb 6, 2017

If we want to make it clear which parts of the keyword value are applied/mapped to which instances, well, we just have to describe how that works.

PR #234.

@Relequestual
Copy link
Member

I'd really much rather see #234 merged FIRST as I'm positive it's the right direction. Then we can look at this change after you've rebased if it still applies. I'm finding it hard to this change given #234

@handrews handrews added this to the draft-next (draft-6) milestone Feb 16, 2017
@awwright awwright closed this Feb 16, 2017
@awwright awwright deleted the aaa-b branch February 16, 2017 22:01
@awwright awwright restored the aaa-b branch February 16, 2017 22:22
@awwright awwright deleted the aaa-b branch February 28, 2018 20:24
@awwright awwright restored the aaa-b branch February 27, 2019 05:34
@awwright awwright deleted the aaa-b branch August 17, 2020 05:37
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Maintenance labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clarification Items that need to be clarified in the specification Priority: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants