- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 357
Standardize on hyphenated format names #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @handrews Sorry for being so slow this week! I've been dealing with some server issues (if you stopped by the IRC channel you probably noticed I'm not there at the moment). I'd like to look over how these terms are used in the wild, usually "uriref" is a single word, for example (formally "URI-Reference"); whereas an RFC3339 string is "date-time" and RFC6570 specifies "URI-Template". I think it makes sense to copy how they're defined in their respective specifications, which mostly seem to prefer the hyphen format. I would vote to keep uriref a single term, but it doesn't matter too much, this is mostly OK. | 
| 
 Ugh, hope that clears up soon- I had looked on IRC to try to get you there before paging you on the PRs today. I'm looking at RFC 3986 "uriref" anywhere. Nor "uri-ref", just "URI-Reference". Am I missing something? If we're going by the spec, it should be "uri-reference" which seems reasonable to shorten to "uri-ref" (although I'd be fine with "uri-reference"). RFC 6570 uses "URI-Template" but never "uritemplate" (in any capitalization). RFC 6901 uses "json-pointer" and never "jsonpointer". So unless there's a source for "uriref" that I'm missing, I think all-hyphenated is clearly the way to go. Let me know if you object, have another reference, or would prefer "uri-reference". Otherwise I'll merge this after it reaches the 2-week mark on Friday since you're objection doesn't seem strong and there's otherwise consensus. | 
576bd8c    to
    0888d3e      
    Compare
  
    When we had ore formats in earlier drafts, all compound names (such as "date-time") were hyphenated. Draft 05 added "uriref" without a hyphen, which started looking weird when we added "uritemplate" and "jsonpointer" without hyphens to match it. This makes everything hyphenated (note "hostname" was deemed to be a single word in this context). "uriref" became "uri-reference" as that is the form that is most common in other RFCs.
0888d3e    to
    dabf8c0      
    Compare
  
    | From IRC: @awwright feels "uri-reference" is more consistent, as it is what is used in other RFCs. I'm fine with this, it's still doing what the issue filers asked, so we're good to merge. | 
When we had more formats in earlier drafts, all compound names
(such as "date-time") were hyphenated. Draft 05 added "uriref"
without a hyphen, which started looking weird when we added
"uritemplate" and "jsonpointer" without hyphens to match it.
This makes everything hyphenated (note "hostname" was deemed
to be a single word in this context).
Addresses issue #207.