-
-
Notifications
You must be signed in to change notification settings - Fork 331
unevaluated* updates (and some annotation dependency cleanup) #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f1422a0
update unevaluated* dependency sections to remove notions of annotati…
gregsdennis 1b620aa
addressing annotation requirements in `contains`
gregsdennis 0eb1821
update unevaluatedItems to remove annotation references
gregsdennis 589fb93
copy unevaluatedItems wording to unevaluatedProperties
gregsdennis a49f095
remove annotation dependency from additional properties
gregsdennis 4316cdf
a bit of cleanup; hard-wrap missed line
gregsdennis 7871920
Update jsonschema-core.md
gregsdennis 2314795
fix section link format
gregsdennis c4953f1
removed mention of indices from items; fix type in contains
gregsdennis a803229
added section about array indexing
gregsdennis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
update unevaluated* dependency sections to remove notions of annotati…
…on control
- Loading branch information
commit f1422a02e216afcd60b87c68c58e077d266cdfe5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that json arrays are indexed from 0: If prefixItems had 3 items, then the items keyword applies to all elements at index 3 and greater, not those greater than 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON 8259 doesn't specify and indexing base. Seems more like a programming language thing to me.
I'll see if I can fix this so that it doesn't mention indices at all.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.rfc-editor.org/rfc/rfc6901.html#section-4 specifies that JSON pointer indexes are zero-based.
I don't see how we can avoid indexes because that's a necessary part of the annotation content for these keywords (and
contains
contains a list of indexes, not just the number of evaluated/validated elements), and we also use array indexes in any JSON pointer in a$ref
, and in keywordLocations and absoluteKeywordLocations in error objects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point. I think it's important to state that we're using zero-based indexing and reference that section.
I'll work that in. Thanks for the... pointer 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left this in as-is (without references to indexing), but I've also added a section specifically about array indices.