More hostname label separator tests #776
Conversation
These are mostly meant to test that the additional `idn-hostname` label separators are treated like `.` and are only allowed between labels.
Regular `hostname` should not support the extended label separators used in `idn-hostname`.
This tests that the extended label separators used in `idn-hostname` properly validate individual labels and don't treat the whole instance as a single label.
|
A lot of these fail in my implementation (they show as valid where the test says it's invalid), but that likely just means I need to mark these as TODO, due to a gap in the library I'm using. |
|
Looking at the IDNA specifications some more, it's unclear if the extended set of label separators is included in RFC 5890. The only reference I can find is in an appendix of RFC 5891 ("Summary of Major Changes from IDNA2003" (RFC 3490)):
Not sure what that means. They're in RFC 3490 (as noted in #760), but I don't know how relevant that is since JSON schema uses 5890 for They're also included in Unicode technical standard 46, which references both IDNA versions. 🤷 Leading/trailing separators are similarly confusing. |
My implementation doesn't yet support all
idn-hostnamelabel separators properly, but (for multiple reasons) it is still passing the tests added here: #760These are the tests I came up with while fixing/reproducing the issues.