Max limit in array is ignored

[jbaydar]

If maxItems is provided, the Add button is still enabled once the limit is reached and the form is still valid. Ideally, when you reach the max, the Add button will switch to disabled.

[engelfrost]

By default everything is styles with Twitter Bootstrap, if you inspect the "Add" button in your browser you will see that the classes .btn, .btn-success and .pull-right are applied to it. Overriding these classes will allow you to style it. Does this answer your second question?

[Dervisevic]

I changed your question around as the maxItem thing seems to be a bug and is more important. As @engelfrost said you can just override those CSS classes in your app to style it.

[jbaydar]

@engelfrost I should have made two separate issues. I created a new issue for the style attribute (#152) and removed it from this issue. @Dervisevic is right. The maxItems bug is higher priority.

[infernalmaster]

To hide 'add' button I just created (copy-paste with some little changes) directives/decorators/bootstrap/array/html. I also hide 'close' button, when modelArray.length <= form.schema.minItems.

<div sf-array="form" ng-model="$$value$$" ng-model-options="form.ngModelOptions">
  <h3 ng-show="form.title && form.notitle !== true">{{ form.title }}</h3>
  <ol class="list-group" ng-model="modelArray" ui-sortable>
    <li class="list-group-item" ng-repeat="item in modelArray track by $index">

<!-- just changed ng-hide -->
      <button ng-hide="form.readonly || (form.schema.minItems && (modelArray.length <= form.schema.minItems))"
              ng-click="deleteFromArray($index)"
              style="position: relative; z-index: 20;"
              type="button" class="close pull-right">
              <span aria-hidden="true">&times;</span><span class="sr-only">Close</span>
      </button>
      <sf-decorator ng-init="arrayIndex = $index" form="copyWithIndex($index)"></sf-decorator>
    </li>
  </ol>
  <div class="clearfix" style="padding: 15px;">

<!-- and there too -->
    <button ng-hide="form.readonly || (form.schema.maxItems && (modelArray.length >= form.schema.maxItems))"
            ng-click="appendToArray()"
            type="button"
            class="btn {{ form.style.add || 'btn-default' }} pull-right">
      <i class="glyphicon glyphicon-plus"></i>
      {{ form.add || 'Add'}}
    </button>
  </div>
  <div class="help-block"
       ng-show="(hasError() && errorMessage(schemaError())) || form.description"
       ng-bind-html="(hasError() && errorMessage(schemaError())) || form.description"></div>
</div>

And then I overloaded decorator for 'array' with my template

angular.module('schemaForm').config(['schemaFormDecoratorsProvider', function(decoratorsProvider) {
  decoratorsProvider.addMapping(
    'bootstrapDecorator',
    'array',
    'some-long-path-to-my-overloaded-file/array.html'
  )
}
])

[infernalmaster]

If you don't want to change default behavior you can add params 'hideCloseWhenMin' and 'hideAddWhenMax' for form. So then

      <button ng-hide="form.readonly || (form.schema.minItems && form.hideCloseWhenMin && (modelArray.length <= form.schema.minItems))"
              ng-click="deleteFromArray($index)"
              style="position: relative; z-index: 20;"
              type="button" class="close pull-right">
              <span aria-hidden="true">&times;</span><span class="sr-only">Close</span>
      </button>

    <button ng-hide="form.readonly || (form.schema.maxItems && form.hideAddWhenMax && (modelArray.length >= form.schema.maxItems))"
            ng-click="appendToArray()"
            type="button"
            class="btn {{ form.style.add || 'btn-default' }} pull-right">
      <i class="glyphicon glyphicon-plus"></i>
      {{ form.add || 'Add'}}
    </button>

[ktatta]

Fixing this would be very useful

[roberttaylortech]

infernalmaster's solution working nicely. Thank you!

Could his adjustment be the actual fix itself? Would be nice to get it incorporated if it's indeed conformant.

Should the title of this issue really say "minItems and maxItems in array are ignored" ?

[david4City]

Any news on that subject ?

[vicary]

This should be fixed already.