Don't fill in stack trace in PathNotFoundException#751
Merged
kallestenflo merged 1 commit intojson-path:masterfrom Nov 4, 2021
Merged
Don't fill in stack trace in PathNotFoundException#751kallestenflo merged 1 commit intojson-path:masterfrom
kallestenflo merged 1 commit intojson-path:masterfrom
Conversation
richardstartin
force-pushed
the
fillinstacktrace
branch
from
2ae2041 to
dedbad3
Compare
Contributor
|
@kallestenflo We are also facing severe performance issues due to this. When can you help with the review and merge for this ? |
|
@kallestenflo are there any plans to cut a new release with this in it? Thanks! |
|
This needs to be configurable for those that need to debug code and are OK with the performance hit. See #838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exception seems to be used for control flow, which leads to high CPU consumption.
This change uses a standard trick to reduce the cost of exception based control flow to virtually nothing.